Skip to content

applications: nrf_desktop: Imply CONFIG_BT_CONN_TX_NOTIFY_WQ #18017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2024
Merged

applications: nrf_desktop: Imply CONFIG_BT_CONN_TX_NOTIFY_WQ #18017

merged 1 commit into from
Oct 22, 2024

Conversation

@MarekPieta
Copy link
Contributor

@MarekPieta MarekPieta commented Oct 18, 2024

Change conditionally implies CONFIG_BT_CONN_TX_NOTIFY_WQ to workaround the MPSL flash synchronization known issue.

Jira: NCSDK-29354

@MarekPieta MarekPieta added the DNM label Oct 18, 2024
@MarekPieta MarekPieta requested a review from a team as a code owner October 18, 2024 14:15
@MarekPieta MarekPieta added this to the 2.8.0 milestone Oct 18, 2024
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 18, 2024
@MarekPieta
Copy link
Contributor Author

MarekPieta commented Oct 18, 2024

Marking as DNM, #17885 must be merged first.

@MarekPieta MarekPieta removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 18, 2024
@MarekPieta MarekPieta requested a review from a team October 18, 2024 14:16
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 18, 2024 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 5

Inputs:

Sources:

sdk-nrf: PR head: ae1eb37021f067a68fb8dc6c6dd53a9000aacd1a

more details

sdk-nrf:

PR head: ae1eb37021f067a68fb8dc6c6dd53a9000aacd1a
merge base: c673d2b5c544d59260a08a8b4531017c11dcd0a2
target head (main): c673d2b5c544d59260a08a8b4531017c11dcd0a2
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (2) 
applications
│  ├── nrf_desktop
│  │  │ Kconfig.ble
doc
│  ├── nrf
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst

Outputs:

Toolchain

Version: 3dd8985b56
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:3dd8985b56_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 72
  • ✅ Integration tests
    • ✅ desktop52_verification
Disabled integration tests
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 18, 2024

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@MarekPieta MarekPieta force-pushed the nrf_desktop_mpsl_timeout_fix branch from 655f301 to 551c6e5 Compare October 21, 2024 14:22
@MarekPieta MarekPieta requested a review from a team as a code owner October 21, 2024 14:22
@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Oct 21, 2024
@MarekPieta MarekPieta removed the DNM label Oct 21, 2024
@MarekPieta MarekPieta force-pushed the nrf_desktop_mpsl_timeout_fix branch from 551c6e5 to 57d416e Compare October 21, 2024 14:24
peknis
peknis requested changes Oct 22, 2024
View reviewed changes
@MarekPieta
applications: nrf_desktop: Imply CONFIG_BT_CONN_TX_NOTIFY_WQ
ae1eb37 
Change conditionally implies CONFIG_BT_CONN_TX_NOTIFY_WQ to work around
the MPSL flash synchronization timeout known issue.

Jira: NCSDK-29354

Signed-off-by: Marek Pieta <[email protected]>
Signed-off-by: Pekka Niskanen <[email protected]>
@MarekPieta MarekPieta force-pushed the nrf_desktop_mpsl_timeout_fix branch from 1ed71fa to ae1eb37 Compare October 22, 2024 08:52
@rlubos rlubos merged commit 17445fa into nrfconnect:main Oct 22, 2024
13 checks passed
@MarekPieta MarekPieta deleted the nrf_desktop_mpsl_timeout_fix branch October 22, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pdunaj pdunaj pdunaj approved these changes

@nordicjm nordicjm nordicjm approved these changes

@peknis peknis peknis approved these changes

@mkapala-nordic mkapala-nordic mkapala-nordic approved these changes

Assignees

No one assigned

Labels

doc-required PR must not be merged without tech writer approval.

Projects

None yet

Milestone

2.8.0

Development

Successfully merging this pull request may close these issues.

7 participants

@MarekPieta @NordicBuilder @pdunaj @nordicjm @peknis @mkapala-nordic @rlubos